Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Dockerfile
Outdated
|
|
||
| RUN cd /src \ | ||
| RUN --mount=type=cache,target=/root/.cache/pip cd /src \ | ||
| && pip install --upgrade pip \ |
There was a problem hiding this comment.
Upgrading pip without pinning can make image builds non-reproducible (pip behavior can change across releases). Consider pinning pip to a known-good version (or using a constraints file) to stabilize builds over time.
There was a problem hiding this comment.
I think pip should always be at the latest version. For other packages I agree.
|
I also suggest building with something newer than python 3.9, but I don't know the background for this. |
Description
Solves #158
Contributor Declaration
By opening this pull request, I affirm the following: