Skip to content

Update base image, pip, add pip cache.#159

Open
ways wants to merge 2 commits intoecmwf:developfrom
ways:dockerbuild
Open

Update base image, pip, add pip cache.#159
ways wants to merge 2 commits intoecmwf:developfrom
ways:dockerbuild

Conversation

@ways
Copy link
Contributor

@ways ways commented Mar 4, 2026

Description

Solves #158

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@shahramn shahramn requested a review from Copilot March 5, 2026 20:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Dockerfile Outdated

RUN cd /src \
RUN --mount=type=cache,target=/root/.cache/pip cd /src \
&& pip install --upgrade pip \
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading pip without pinning can make image builds non-reproducible (pip behavior can change across releases). Consider pinning pip to a known-good version (or using a constraints file) to stabilize builds over time.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pip should always be at the latest version. For other packages I agree.

@ways
Copy link
Contributor Author

ways commented Mar 6, 2026

I also suggest building with something newer than python 3.9, but I don't know the background for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants