Repository navigation
fix(boot): fix bugs found in a review of the bootloader - #124
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review of the bootloader turned up five bugs, each fixed in its own commit.
--config=\path\to\config.tomlloaded the wrong path. The splitter now keeps them, and theshlexdependency is gone.bls.pathand driver paths. Stamping now repeats until the text settles, within the existing limits.Builds and clippy pass on both targets, and the
blsandparsingtests pass. I have not booted these changes in QEMU.Not fixed here: the version comparison of
1.0against1.a(an existing test pins the current result), the graphical menu countdown that stalls on spurious firmware wakes, and a few cosmetic or edge-case issues.