fix(chat): resume after server restart no longer reopens a closed chat#250
Merged
ericdallo merged 1 commit intoJun 11, 2026
Merged
Conversation
ericdallo
approved these changes
Jun 11, 2026
Resuming a previous session after a server restart reopened it as a "*Closed session*" buffer that rejected new prompts. `eca-chat-exit' marks the most-recent chat buffer `eca-chat--closed' on restart but leaves it in the session registry, so when the server replayed the chat via `chat/open' -> `chat/opened', the handler reused that stale closed buffer instead of creating a fresh one. `eca-chat-opened' now treats a registered buffer marked `eca-chat--closed' as stale: it kills the leftover buffer and creates a fresh, writable one in its place. Adds regression tests covering the stale-closed and live-non-closed cases.
rschmukler
force-pushed
the
rs/fix-chat-resume
branch
from
60accbc to
1c72f4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resuming a previous session after a server restart reopened it as a "Closed session" buffer that rejected new prompts.
eca-chat-exit' marks the most-recent chat buffereca-chat--closed' on restart but leaves it in the session registry, so when the server replayed the chat viachat/open' ->chat/opened', the handler reused that stale closed buffer instead of creating a fresh one.eca-chat-opened' now treats a registered buffer markedeca-chat--closed' as stale: it kills the leftover buffer and creates a fresh, writable one in its place. Adds regression tests covering the stale-closed and live-non-closed cases.