Fix stale paint when switching Settings tabs (#21)#23
Merged
Conversation
JBCefBrowser was built with setOffScreenRendering true. Under OSR, CEF intermittently fails to invalidate the freed region when a large React subtree is replaced in one commit (e.g. switching out of LogsTab with thousands of buffered entries), leaving the previous tab's pixels visible behind the new one until any other event triggers a repaint. OSR was set in the initial webview scaffolding (7c0511b) with a "TODO move to config" note and no specific need for transparency or custom compositing. Switched to heavyweight rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JBCefBrowserwas built withsetOffScreenRendering true. Under OSR, CEF intermittently fails to invalidate freed regions when a large React subtree is replaced in one commit (e.g. switching out ofLogsTabwith thousands of buffered entries), leaving the previous tab's pixels visible behind the new one until another event triggers a repaint.7c0511b) with aTODO move to confignote and no specific need for transparency or custom compositing.Closes #21.