test(#2523 후속): composeImageFilter 효과별 CSS filter 문자열 pin - #2664
Closed
planet6897 wants to merge 1 commit into
Closed
planet6897 wants to merge 1 commit into
planet6897 wants to merge 1 commit into
Conversation
PR edwardkim#2523 검토 권고 대응 — 회색조/pattern8x8/흑백(contrast 1000%)/밝기·명암 스케일/조합/baked watermark 제외/비유한 입력 정규화를 직접 pin. web_canvas.rs::compose_image_filter 와의 동일 산출 계약 가드. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
|
@planet6897 감사합니다. 이 변경은 #2732에 체리픽 통합되어 merge됐습니다.
원 DOM flow-image 계약을 직접 고정하는 회귀 테스트로 수용했습니다. 이 원 PR은 통합 PR로 대체되어 close합니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
대상
PR #2523 검토(pr_2523_review.md)의 후속 권고 대응:
내용
rhwp-studio/tests/flow-image-clip.test.ts에composeImageFilter()효과별 CSS filter 문자열 pin 3케이스(단정 13건) 추가:realPic/기본=null,grayScale·pattern8x8=grayscale(100%),blackWhite=grayscale(100%) contrast(1000%)brightness(1.2000)/contrast(0.7000)등 소수 4자리 고정 +grayScale+밝기+명암 조합 순서bakedWatermark(효과 기적용 픽셀)=null, 비유한(NaN/Infinity)·비문자 effect 입력 정규화pin 문자열은
web_canvas.rs::compose_image_filter구현({:.4}포맷)과 대조해 동일 산출 계약을 가드한다 — 문자열이 갈라지면 WASM canvas 경로와 DOM flow-image 경로의 그림 효과가 달라진다.검증
node --test tests/flow-image-clip.test.ts5/5 GREEN (기존 2 + 신규 3)compose_image_filter소스 대조로 기대 문자열 동일성 확인🤖 Generated with Claude Code