Skip to content

(RFC) Crashfix: Do not feed certain bogus utf8 into python bindings #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelortmann wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

(RFC) Crashfix: Do not feed certain bogus utf8 into python bindings #1747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions src/tclhash.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,43 @@ int check_tcl_bind(tcl_bind_list_t *tl, const char *match,
* specified because we want to trigger all binds in a stack.
*/

if (!strncmp(tc->func_name, "*python:", strlen("*python:"))) {
const uint8_t* b = (const uint8_t*) match;
int utf8_error = 0;
while (*b) {
if (!(*b & 0x80))
b++;
else if ((*b & 0xe0) == 0xc0) {
if (b[1] == 0) {
utf8_error = 1;
break;
}
b += 2;
} else if ((*b & 0xf0) == 0xe0) {
if (b[1] == 0 || b[2] == 0) {
utf8_error = 1;
break;
}
b += 3;
} else if ((*b & 0xf8) == 0xf0) {
if (b[1] == 0 || b[2] == 0 || b[3] == 0) {
utf8_error = 1;
break;
}
b += 4;
} else {
utf8_error = 1;
break;
}
}
if (utf8_error) {
putlog(LOG_MISC, "*", "bogus utf8, python bind \"%s\" not triggered\n", tc->func_name);
continue;
}
}

tc->hits++;

x = trigger_bind(tc->func_name, param, tm->mask);

if (match_type & BIND_ALTER_ARGS) {
Expand Down