Skip to content

Conversation

@erickzhao
Copy link
Member

@erickzhao erickzhao commented Dec 4, 2025

Pre-requisite for some of the Node 22 work in #4059 because of some import.meta.resolve implementation issues with Vitest that were fixed upstream.

This PR:

  • Upgrades to Vitest 4 via yarn up.
  • Upgrades the root workspace's version of Vite to 7 (to pick up import.meta.resolve fix). I needed to add an exception to the Yarn Constraints for the time being.
  • Migrates vitest.workspace.mts to the projects key in vitest.config.mts.
  • Updated PublisherS3.spec.ts to use vi.importActual, since applying vi.mock('node:fs') in Vitest 4 actually mocks out the fixture code too.

@erickzhao erickzhao requested a review from a team as a code owner December 4, 2025 21:03
@erickzhao erickzhao added the next label Dec 4, 2025
@socket-security
Copy link

socket-security bot commented Dec 4, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedvitest@​3.1.3 ⏵ 4.0.1498 +11007999100
Updatedvite@​6.4.1 ⏵ 7.2.498 +31008298 -1100

View full report

@socket-security
Copy link

socket-security bot commented Dec 4, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

View full report

@erickzhao
Copy link
Member Author

@SocketSecurity ignore npm/[email protected]

Looks like Vite/Vitest forked the old debug module:

vitest-dev/vitest#9057

@erickzhao erickzhao mentioned this pull request Dec 4, 2025
17 tasks
@erickzhao erickzhao requested a review from erikian December 5, 2025 18:36
@erickzhao erickzhao merged commit 4a6dafe into next Dec 5, 2025
11 checks passed
@erickzhao erickzhao deleted the vitest-4 branch December 5, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants