README: Add gettext to deps#684
Merged
Merged
Conversation
Added gettext requirement
added cmake dependency
granite-7 is the name of the package on elementary os
danirabbit
previously requested changes
Nov 16, 2025
removed gtk4 thing
removed cmake
LuminousHustler
commented
Nov 20, 2025
Contributor
Author
LuminousHustler
left a comment
LuminousHustler
left a comment
There was a problem hiding this comment.
removed cmake
Contributor
Author
|
It's not totally clear to me (just because github is being github) what is in there. But this pull request shouldn't have any changes to meson.build or anything other that gettext in the readme. Let me know if something still looks messed up and I'll be happy to take another stab at it. And thank you for your patience while I figure out how to use the site :) |
ryonakano
approved these changes
Nov 20, 2025
Member
ryonakano
left a comment
ryonakano
left a comment
There was a problem hiding this comment.
Thank you for adding this and addressing changes request!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added gettext requirement