Add keyboard shortcut and hotcorners for notifications menu - #2914
Closed
danirabbit wants to merge 5 commits into
Closed
Add keyboard shortcut and hotcorners for notifications menu#2914danirabbit wants to merge 5 commits into
danirabbit wants to merge 5 commits into
Conversation
danirabbit
marked this pull request as ready for review
August 27, 2026 16:56
Member
|
You should create keyboard shortcuts via org.gnome.Shell dbus interface like we did it in dock (elementary/dock#245) |
Member
Author
|
Ohhh interesting thanks for the tip |
Member
Author
|
@lenemter It looks like to do that we need to do a lot of refactoring because the sound indicator already registers a keygrabber for the panel process But also, then we wouldn't get the hotcorner. I think it has to live here for that reason anyways right? |
Member
|
@danirabbit Replied in elementary/wingpanel#698. Also why do we need hotcorner for this in the first place? This was not mentioned in the original issue nor was it discussed anywhere else |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes elementary/panel-notifications#313