AppEntry: don't hold references to Notifications - #307
Merged
Conversation
lenemter
reviewed
Aug 27, 2026
lenemter
reviewed
Aug 27, 2026
This comment was marked as resolved.
This comment was marked as resolved.
danirabbit
marked this pull request as draft
August 27, 2026 15:24
danirabbit
marked this pull request as ready for review
August 28, 2026 18:09
danirabbit
commented
Aug 28, 2026
Member
Author
|
@lenemter can I get a re-review please :) |
lenemter
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that AppEntry is as dumb as possible and not referencing NotificationEntries all over the place