NotificationEntry: construct once then set gicon - #309
Merged
Conversation
jeremypw
approved these changes
Aug 30, 2026
jeremypw
left a comment
jeremypw
left a comment
Collaborator
There was a problem hiding this comment.
Makes sense as part of a roadmap.
danirabbit
enabled auto-merge (squash)
August 30, 2026 13:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we switch to ListView we're going to want
notificationto be a settable property so that we can recycle widgets. This makes it so we construct the Images once and then set gicons.Fixes an issue where we sometimes got a checkerboard with image missing instead of just showing the app icon and where notify-send notifications had image missing