Skip to content

Jeremypw/fix new root tab - #1019

Merged
jeremypw merged 5 commits into
mainfrom
jeremypw/fix-new-root-tab
Aug 28, 2026
Merged

Jeremypw/fix new root tab#1019
jeremypw merged 5 commits into
mainfrom
jeremypw/fix-new-root-tab

Conversation

@jeremypw

@jeremypw jeremypw commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Fixes #485

SImilar in intent to #959 but implemented a little differently.

  • Simplify MainWindow
    • Restoring tab function only does that.
    • Adding a tab only does that
    • Lose recreate_tabs construct property
  • TerminalView
    • Adding a tab returns the resulting page (ease of selecting)
  • Refactor Application.command_line
    • Take care of whether tabs are restored
    • Take care of which tab is selected
    • Take care of ensuring at least one tab
    • Do not restore or add new or default tab execute or command-line option found

@jeremypw
jeremypw marked this pull request as ready for review August 27, 2026 16:24
@jeremypw
jeremypw requested a review from a team August 27, 2026 16:24
Comment thread src/Application.vala Outdated
Comment thread src/MainWindow.vala Outdated
Comment thread src/MainWindow.vala Outdated
@jeremypw
jeremypw merged commit 4e1aadb into main Aug 28, 2026
4 checks passed
@jeremypw
jeremypw deleted the jeremypw/fix-new-root-tab branch August 28, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When a new window is opened, a non-root tab is initialized.

2 participants