Skip to content

Comments

Port to GTK4#579

Merged
danirabbit merged 22 commits intomasterfrom
leolost/gtk4-new
Feb 19, 2026
Merged

Port to GTK4#579
danirabbit merged 22 commits intomasterfrom
leolost/gtk4-new

Conversation

@leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Sep 17, 2024

Fixes #655
closes #542

This should work now.

Todo:

  • window drag doesn't work on X11 (i'd like to treat this as not blocking because I'm not quite sure what's going on here and kinda consider X11 only legacy anyways but idk)
  • The transparency doesn't fully work (probably a CSS issue idk)

Misc:

  • We get a warning about gtk_is_ancestor receiving null everytime an indicator is opened but idk why and wouldn't consider it blocking i guess?

@leolost2605 leolost2605 marked this pull request as ready for review September 18, 2024 15:07
@danirabbit
Copy link
Member

I think probably the best way forward for development is I can create a new packaging branch based on this branch and then build that in daily so we can start building indicators against it etc

But I'm not sure what trying to upgrade this mid-cycle looks like, so I'd like to leave it unmerged for now until we have a plan around how to handle the packaging/upgrade.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update deps on README and .github :)

@danirabbit
Copy link
Member

There's a packaging branch now: https://github.com/elementary/wingpanel/tree/deb-packaging-gtk4

So we should have access to the library on OS 8 daily no problem to work with porting the other indicators when this builds: https://code.launchpad.net/~elementary-os/+recipe/wingpanel-8-daily

You might want to temporarily change the meson project name here to io.elementary.wingpanel-8 or something so that you can install them both at the same time for testing? Otherwise the io.elementary.wingpanel-8 package will refuse to install because of the file conflicts. But this package name will eventually be reverted anyways so that's optional I guess 🤷‍♀️

@danirabbit
Copy link
Member

Looks like we didn't properly update the library stuff so we could at least try to build indicators:

 trying to overwrite '/usr/include/wingpanel/wingpanel.h', which is also in package libwingpanel-dev 8.0.3+r719+pkg73~daily~ubu
ntu8.1

@leolost2605
Copy link
Member Author

Looks like we didn't properly update the library stuff so we could at least try to build indicators:
trying to overwrite '/usr/include/wingpanel/wingpanel.h', which is also in package libwingpanel-dev 8.0.3+r719+pkg73dailyubu
ntu8.1

@danirabbit I did something in #605 lmk if that's right :)

@danirabbit

This comment has been minimized.

@danirabbit
Copy link
Member

danirabbit commented Jun 6, 2025

Finally starting to test this! It looks like we've got some issues with

  • Indicators losing focus
  • The panel not being transparent when it should be. Changing the wallpaper sets it correctly but then if you switch workspaces for example it'll go back to being opaque
  • Clicking inside an indicator closes that indicator and clicks on buttons etc aren't accepted

Screenshot from 2025-06-06 12 12 44

@danirabbit
Copy link
Member

Interestingly, I can't reproduce the issue with indicators closing without accepting clicks on my Starlite running at 1.5x scaling. So I wonder if it has to do with scaling somehow?

@danirabbit danirabbit moved this from Blocked to In Progress in GTK4 Porting Jun 16, 2025
@danirabbit

This comment was marked as resolved.

@danirabbit danirabbit added this to OS 9 Jan 13, 2026
@danirabbit danirabbit moved this to Needs Review in OS 9 Jan 13, 2026
@danirabbit
Copy link
Member

I want to get this going. I'm fine with broken X support because we have to remove that anyways. Proposed the companion packaging branch here: #667

Dailies for wingpanel are only building for resolute now: https://code.launchpad.net/~elementary-os/+recipe/wingpanel-daily

@danirabbit danirabbit moved this from In Progress to Needs Review in GTK4 Porting Feb 18, 2026
@danirabbit danirabbit merged commit 1958f5d into master Feb 19, 2026
5 of 6 checks passed
@danirabbit danirabbit deleted the leolost/gtk4-new branch February 19, 2026 16:50
@github-project-automation github-project-automation bot moved this from Needs Review to Done in OS 9 Feb 19, 2026
@github-project-automation github-project-automation bot moved this from Needs Review to Done in GTK4 Porting Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

Tooltips position does not correct

4 participants