Fix Conversational AI audio chunk handling and WebSocket error recovery#727
Open
18-RAJAT wants to merge 1 commit intoelevenlabs:mainfrom
Open
Fix Conversational AI audio chunk handling and WebSocket error recovery#72718-RAJAT wants to merge 1 commit intoelevenlabs:mainfrom
18-RAJAT wants to merge 1 commit intoelevenlabs:mainfrom
Conversation
18-RAJAT
commented
Feb 3, 2026
18-RAJAT
commented
- Add audio chunk queue/buffer to prevent loss during transient WebSocket failures
- Improve error handling to distinguish between fatal and recoverable errors
- Add connection state checking before sending audio chunks
- Add proper exception handling for WebSocket errors (including 1011 internal error)
- Use dedicated thread/task for sending audio chunks to prevent blocking
- Handle ConnectionClosedOK, ConnectionClosedError, and ConnectionClosed exceptions gracefully
- Prevent session termination on transient errors to improve reliability
- Add audio chunk queue/buffer to prevent loss during transient WebSocket failures - Improve error handling to distinguish between fatal and recoverable errors - Add connection state checking before sending audio chunks - Add proper exception handling for WebSocket errors (including 1011 internal error) - Use dedicated thread/task for sending audio chunks to prevent blocking - Handle ConnectionClosedOK, ConnectionClosedError, and ConnectionClosed exceptions gracefully - Prevent session termination on transient errors to improve reliability
|
First off - thanks a lot for your interest in the project! This PR addresses a bit too many issues at once for us to reliably review and merge - especially since this is your first PR to our projects. Could I get you to separate this out into:
This will make it easier for us to review and potentially partially revert if this (against expectations) introduce new bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.