Fix tuple_insert_static crash on non-normalized empty type - #15542
Merged
josevalim merged 2 commits intoJul 25, 2026
Conversation
gldubc
approved these changes
Jul 24, 2026
gldubc
left a comment
gldubc
left a comment
Member
There was a problem hiding this comment.
I think those changes are good, there is no need to refactor for normalization I agree.
Member
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a minimal change and instead of matching on
nonetype asserts that static component has tuple and returnsnone()on everything else. Returningbadtuplehere would be incorrect. A few lines up the decision was made that we are dealing with a proper tupledynamic component is a tuple, static is a non-normalized empty type, for which
tuple_only?returns trueAlternative approach would be to normalize empty list/tuple/map components at construction but that's a bigger refactor I would not attempt
Fixes #15541
Assisted-by: Claude Opus 4.8