Skip to content

Fix Date.range/3 raises wrong exception for invalid step #15690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 2 commits into from
Jul 28, 2026
+5 −1
Merged

Fix Date.range/3 raises wrong exception for invalid step #15690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84121d0
Fix Date.range/3 raises wrong exception for invalid step
AlexGx Jul 28, 2026
e83d350
Apply suggestion from @josevalim
josevalim Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/elixir/lib/calendar/date.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ defmodule Date do
) do
raise ArgumentError,
"both dates must have matching calendar and the step must be a " <>
"non-zero integer, got: #{inspect(first)}, #{inspect(last)}, #{step}"
"non-zero integer, got: #{inspect(first)}, #{inspect(last)}, #{inspect(step)}"
end

defp range(first, first_days, last, last_days, calendar, step) do
Expand Down
4 changes: 4 additions & 0 deletions lib/elixir/test/elixir/calendar/date_range_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,10 @@ defmodule Date.RangeTest do
assert_raise ArgumentError, message, fn ->
Date.range(~D[2000-01-01], ~D[2000-01-31], step)
end

assert_raise ArgumentError, ~r/got: ~D\[2000-01-01\], ~D\[2000-02-01\], \{1\}/, fn ->
Date.range(~D[2000-01-01], ~D[2000-02-01], {1})
end
end

describe "old date ranges" do
Expand Down
Loading