Skip to content

Optimize key lookups in Macro #15706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Jul 31, 2026
+6 −7
Merged

Optimize key lookups in Macro #15706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lib/elixir/lib/macro.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1740,9 +1740,9 @@ defmodule Macro do

defp kw_blocks_to_string(kw, fun) do
Enum.reduce(unquote(kw_keywords), " ", fn x, acc ->
case Keyword.has_key?(kw, x) do
true -> acc <> kw_block_to_string(x, Keyword.get(kw, x), fun)
false -> acc
case Keyword.fetch(kw, x) do
{:ok, value} -> acc <> kw_block_to_string(x, value, fun)
:error -> acc
end
end) <> "end"
end
Expand Down Expand Up @@ -1981,10 +1981,9 @@ defmodule Macro do

defp do_expand_once({{:., _, [{:__ENV__, _, atom}, field]}, _, []} = original, env)
when is_atom(atom) and is_atom(field) and env.context != :match do
if Map.has_key?(env, field) do
{maybe_escape_map(Map.get(env, field)), true}
else
{original, false}
case Map.fetch(env, field) do
{:ok, value} -> {maybe_escape_map(value), true}
:error -> {original, false}
end
end

Expand Down
Loading