Skip to content

use tail recursion in tuple aggregates #15708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkuku wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −6
Open

use tail recursion in tuple aggregates #15708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad6b356
use tail recursion
dkuku Jul 31, 2026
63237ed
format
dkuku Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions lib/elixir/lib/tuple.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,12 @@ defmodule Tuple do
"""
@doc since: "1.12.0"
@spec sum(tuple) :: number()
def sum(tuple), do: sum(tuple, tuple_size(tuple))
def sum(tuple), do: sum(tuple, 1, tuple_size(tuple) + 1, 0)

defp sum(_tuple, 0), do: 0
defp sum(tuple, index), do: :erlang.element(index, tuple) + sum(tuple, index - 1)
defp sum(_tuple, top, top, acc), do: acc

defp sum(tuple, index, top, acc),
do: sum(tuple, index + 1, top, acc + :erlang.element(index, tuple))

@doc """
Computes a product of tuple elements.
Expand All @@ -151,10 +153,12 @@ defmodule Tuple do
"""
@doc since: "1.12.0"
@spec product(tuple) :: number()
def product(tuple), do: product(tuple, tuple_size(tuple))
def product(tuple), do: product(tuple, 1, tuple_size(tuple) + 1, 1)

defp product(_tuple, top, top, acc), do: acc

defp product(_tuple, 0), do: 1
defp product(tuple, index), do: :erlang.element(index, tuple) * product(tuple, index - 1)
defp product(tuple, index, top, acc),
do: product(tuple, index + 1, top, acc * :erlang.element(index, tuple))

@doc """
Converts a tuple to a list.
Expand Down
Loading