This repository was archived by the owner on Sep 14, 2023. It is now read-only.
Include location data sent to Bot - #47
Open
Schwad wants to merge 2 commits into
Open
Conversation
This PR includes locations sharing from the user to the bot. The workflow is when clicking 'Send my current location' a new message is sent to the bot with latitude and longitude accessed via `my_message.location`. To get the coordinates in an array, this can be accessed via `my_message.location.full`. Original api discussion [here](https://core.telegram.org/bots/api#location). This PR does *not* implement sharing of live locations, which are [implemented in a wholly different manner](https://telegram.org/blog/live-locations) by nesting the information within `edited_message`. To include live locations we would also need to bring in the `edited_message` functionality. I will be approaching this with my next PR.
Collaborator
Author
|
Commit incoming for spec passing :) |
Collaborator
Author
|
@eljojo Quick question: On travis it's trying to make the following request: But of course we want this request to grab the VCR cassette: What am I missing here to get the ENV variables in travis triggering? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes locations sharing from the user to the bot.
The workflow: when clicking
Send my current locationa new messageis sent to the bot with latitude and longitude accessed via
my_message.location.To get the coordinates in an array, use
my_message.location.full.Original api discussion here.
This PR does not implement sharing of live locations, which are
implemented in a wholly different manner by nesting
the information within
edited_message. To include live locations wewould also need to bring in the
edited_messagefunctionality. I willbe approaching this with my next PR.