fix: #7936 - #7940
Conversation
… workflow for package publishing.
Removed the 'Test' step from the workflow.
…` and introduce base class for endpoints without input models.
|
PR author is not in the allowed authors list. |
|
@dotnet-policy-service agree [company="Néctar Sistemas"] |
|
@dotnet-policy-service agree @dotnet-policy-service agree company="Néctar Sistemas" |
|
@copilot resolve the merge conflicts in this pull request |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 35183230 | Triggered | Generic High Entropy Secret | 233d15f | src/apps/Elsa.ModularServer.Web/appsettings.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
# Conflicts: # src/apps/Elsa.Server.Web/Program.cs
|
Hello @sfmskywalker , there seem to be a problem with my pull request because of a secret uncovered, but I've checked my source code and could not find this secret. |
Purpose
This PR updates the FastEndpoints package version to fix versions mismatches when using FastEndpoints in a solution with central package management.
Scope
Select one primary concern:
Description
Problem
Elsa was using an old version of FastEndpoints, and when using central package management in a solution it would not work with newer versions.
Besides that, the newer versions of FastEndpoints will throw an exception when using a Request with no public properties, so this PR also addresses that.
Solution
Update the FastEndpoints package version, create another abstract endpoint that will get an EmptyRequest (FastEndpoints solution for request without public properties).
Verification
Steps:
Expected outcome:
Swagger UI with all the endpoints.
Screenshots / Recordings (if applicable)
Commit Convention
We recommend using conventional commit prefixes:
fix:– Bug fixes (behavior change)feat:– New featuresrefactor:– Code changes without behavior changedocs:– Documentation updateschore:– Maintenance, tooling, or dependency updatestest:– Test additions or modificationsClear commit messages make reviews easier and history more meaningful.
Checklist