Skip to content

fix: #7936 - #7940

Open
diegomodolo wants to merge 15 commits into
elsa-workflows:mainfrom
diegomodolo:main
Open

fix: #7936#7940
diegomodolo wants to merge 15 commits into
elsa-workflows:mainfrom
diegomodolo:main

Conversation

@diegomodolo

@diegomodolo diegomodolo commented Aug 13, 2026

Copy link
Copy Markdown

Purpose

This PR updates the FastEndpoints package version to fix versions mismatches when using FastEndpoints in a solution with central package management.


Scope

Select one primary concern:

  • Bug fix (behavior change)
  • Refactor (no behavior change)
  • Documentation update
  • Formatting / code cleanup
  • Dependency / build update
  • New feature

Description

Problem

Elsa was using an old version of FastEndpoints, and when using central package management in a solution it would not work with newer versions.
Besides that, the newer versions of FastEndpoints will throw an exception when using a Request with no public properties, so this PR also addresses that.

Solution

Update the FastEndpoints package version, create another abstract endpoint that will get an EmptyRequest (FastEndpoints solution for request without public properties).

Verification

Steps:

  1. Update the FastEndpoins version on a solution that also uses Elsa.
  2. Run the solution and check that /swagger works and shows all the endpoints.

Expected outcome:

Swagger UI with all the endpoints.

Screenshots / Recordings (if applicable)


Commit Convention

We recommend using conventional commit prefixes:

  • fix: – Bug fixes (behavior change)
  • feat: – New features
  • refactor: – Code changes without behavior change
  • docs: – Documentation updates
  • chore: – Maintenance, tooling, or dependency updates
  • test: – Test additions or modifications

Clear commit messages make reviews easier and history more meaningful.


Checklist

  • The PR is focused on a single concern
  • Commit messages follow the recommended convention
  • Tests added or updated (if applicable)
  • Documentation updated (if applicable)
  • No unrelated cleanup included
  • All tests pass

@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

PR author is not in the allowed authors list.

@diegomodolo

Copy link
Copy Markdown
Author

@dotnet-policy-service agree [company="Néctar Sistemas"]

@diegomodolo

Copy link
Copy Markdown
Author

@dotnet-policy-service agree

@dotnet-policy-service agree company="Néctar Sistemas"

@sfmskywalker

Copy link
Copy Markdown
Member

@copilot resolve the merge conflicts in this pull request

@gitguardian

gitguardian Bot commented Aug 17, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
35183230 Triggered Generic High Entropy Secret 233d15f src/apps/Elsa.ModularServer.Web/appsettings.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@diegomodolo

Copy link
Copy Markdown
Author

Hello @sfmskywalker , there seem to be a problem with my pull request because of a secret uncovered, but I've checked my source code and could not find this secret.
I am not familiar with GitGuardian, could you help me find the problem so I can fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants