Fix normalizeRotation page size retrieval#522
Open
shunyy wants to merge 1 commit intoembedpdf:mainfrom
Open
Conversation
…ormalized EPDF_GetPageSizeByIndexNormalized reads MediaBox/CropBox directly from the page dictionary without resolving page tree inheritance, which produces incorrect dimensions for PDFs where these boxes are inherited from parent /Pages nodes. Replace with FPDF_GetPageSizeByIndexF (which correctly resolves inheritance via CPDF_Page) and swap width/height in the application layer for 90°/270° rotated pages when normalizeRotation is enabled. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@shunyy is attempting to deploy a commit to the OpenBook Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #521
Summary
Replace
EPDF_GetPageSizeByIndexNormalizedwithFPDF_GetPageSizeByIndexF+ application-side dimension swap fornormalizeRotationmode.Problem
Page dimensions were incorrectly retrieved for certain PDFs when opened with
normalizeRotation: true.Root Cause
EPDF_GetPageSizeByIndexNormalizedwas designed to be lightweight by reading MediaBox/CropBox directly from the page dictionary viadict->GetRectFor()without constructing aCPDF_Page. However, this does not resolve PDF page tree attribute inheritance.Affected PDFs
used instead of the inherited value
Construction_plan_partial_render_demo.pdf
H21_OilPan.pdf