Repository navigation
Fix pluralize/singularize replacing an irregular word that is not at the end - #541
Merged
NullVoxPopuli merged 1 commit intoNov 16, 2026
Merged
Conversation
inflect() checked that the irregular key matches at the end, but then
replaced the first match anywhere in the word, so pluralize('management/chairman')
gave 'menagement/chairman'. Anchor the replace regex to the end too.
Fixes #540
NullVoxPopuli
approved these changes
Nov 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #540
inflect()checks that an irregular key matches at the end of the word (lowercase.match(`${key}$`)), but then doesword.replace(new RegExp(rule, 'i'), substitution), which replaces the first match anywhere in the word. So when the irregular word also shows up earlier, the wrong part is changed:pluralize('management/chairman')menagement/chairmanmanagement/chairmenpluralize('personal-spokesperson')peopleal-spokespersonpersonal-spokespeoplepluralize('personalContactPerson')PeoplealContactPersonpersonalContactPeoplepluralize('child/grandchild')children/grandchildchild/grandchildrensingularize('department-chairmen')departmant-chairmendepartment-chairmansingularize('personalContactPerson')PersonalContactPersonpersonalContactPersonThe fix anchors the replace regex to the end too (
`${rule}$`), the same as the check above it. Words where the irregular part only appears at the end are unchanged.Added a unit test with the cases above. It fails on master and passes with the change; the full suite (55 tests) passes in headless Chrome.
prettier --check,eslintandember-tsc --noEmitare clean.