Remove some IE11 support (Symbols) by NullVoxPopuli · Pull Request #21079 · emberjs/ember.js

NullVoxPopuli · 2026-02-08T21:26:07Z

We dropped IE11 long ago, and forgot to clean this up

bench results are unchanged

duration phase no difference [-114ms to 80ms]
renderEnd phase no difference [-3ms to 2ms]
render1000Items1End phase no difference [-6ms to 22ms]
clearItems1End phase no difference [0ms to 2ms]
render1000Items2End phase estimated improvement -1ms [-17ms to 0ms] OR -0.22% [-7.18% to -0.02%]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase no difference [-43ms to 17ms]
clearManyItems1End phase no difference [-3ms to 7ms]
render5000Items2End phase no difference [-51ms to 33ms]
clearManyItems2End phase no difference [-4ms to 2ms]
render1000Items3End phase no difference [0ms to 0ms]
append1000Items1End phase no difference [-16ms to 17ms]
append1000Items2End phase no difference [-16ms to 33ms]
updateEvery10thItem1End phase no difference [0ms to 16ms]
updateEvery10thItem2End phase no difference [0ms to 0ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [0ms to 16ms]
removeSecondRow1End phase no difference [0ms to 16ms]
swapRows1End phase no difference [0ms to 0ms]
swapRows2End phase no difference [0ms to 0ms]
clearItems4End phase no difference [0ms to 0ms]
paint phase no difference [0ms to 0ms]

artifact-2.pdf

NullVoxPopuli · 2026-02-08T21:29:46Z

packages/@ember/-internals/utils/lib/symbol.ts

-// This code exists for that, and as a fallback in IE11. In general, prefer
-// `symbol` below when creating a new symbol.
-export function enumerableSymbol(debugName: string): string {
-  // TODO: Investigate using platform symbols, but we do not


github-actions · 2026-02-08T21:30:34Z

Estimated Asset Sizes

Diff

--- main/out.txt	2026-02-06 20:32:44.000000000 +0000
+++ pr/./pr-21806644814/out.txt	2026-02-08 22:36:28.000000000 +0000
@@ -1,46 +1,46 @@
 ╔═══════╤═══════════╤═══════════╗
 ║       │ Min       │ Gzip      ║
 ╟───────┼───────────┼───────────╢
-║ Total │ 352.26 KB │ 203.59 KB ║
+║ Total │ 351.99 KB │ 203.81 KB ║
 ╚═══════╧═══════════╧═══════════╝
 
 ╔══════════════════════╤═══════════╤═══════════╗
 ║ @ember/*             │ Min       │ Gzip      ║
 ╟──────────────────────┼───────────┼───────────╢
-║ Total                │ 313.87 KB │ 181.83 KB ║
+║ Total                │ 313.6 KB  │ 182.07 KB ║
 ╟──────────────────────┼───────────┼───────────╢
-║ -internals           │ 36.68 KB  │ 25.99 KB  ║
-║ application          │ 13.24 KB  │ 7.99 KB   ║
-║ array                │ 13.05 KB  │ 7.54 KB   ║
+║ -internals           │ 36.61 KB  │ 25.96 KB  ║
+║ application          │ 13.24 KB  │ 8.13 KB   ║
+║ array                │ 13.05 KB  │ 7.55 KB   ║
 ║ canary-features      │ 304 B     │ 419 B     ║
-║ component            │ 2.05 KB   │ 1.63 KB   ║
-║ controller           │ 1.96 KB   │ 1.45 KB   ║
-║ debug                │ 11.73 KB  │ 8.14 KB   ║
+║ component            │ 2.05 KB   │ 1.61 KB   ║
+║ controller           │ 1.9 KB    │ 1.43 KB   ║
+║ debug                │ 11.73 KB  │ 8.16 KB   ║
 ║ deprecated-features  │ 31 B      │ 77 B      ║
 ║ destroyable          │ 561 B     │ 383 B     ║
 ║ enumerable           │ 259 B     │ 387 B     ║
-║ helper               │ 1.08 KB   │ 841 B     ║
+║ helper               │ 1.08 KB   │ 834 B     ║
 ║ instrumentation      │ 2.43 KB   │ 1.78 KB   ║
-║ modifier             │ 1.22 KB   │ 991 B     ║
-║ object               │ 35.98 KB  │ 22.1 KB   ║
+║ modifier             │ 1.22 KB   │ 984 B     ║
+║ object               │ 35.84 KB  │ 22.23 KB  ║
 ║ owner                │ 159 B     │ 178 B     ║
-║ renderer             │ 630 B     │ 509 B     ║
-║ routing              │ 59.37 KB  │ 33.94 KB  ║
-║ runloop              │ 2.36 KB   │ 1.5 KB    ║
-║ service              │ 1 KB      │ 858 B     ║
-║ template             │ 654 B     │ 535 B     ║
+║ renderer             │ 630 B     │ 494 B     ║
+║ routing              │ 59.37 KB  │ 34.05 KB  ║
+║ runloop              │ 2.36 KB   │ 1.45 KB   ║
+║ service              │ 1 KB      │ 855 B     ║
+║ template             │ 654 B     │ 541 B     ║
 ║ template-compilation │ 429 B     │ 366 B     ║
 ║ template-compiler    │ 123.33 KB │ 59.61 KB  ║
 ║ template-factory     │ 370 B     │ 385 B     ║
 ║ test                 │ 923 B     │ 627 B     ║
-║ utils                │ 4.11 KB   │ 3.63 KB   ║
+║ utils                │ 4.11 KB   │ 3.62 KB   ║
 ║ version              │ 55 B      │ 131 B     ║
 ╚══════════════════════╧═══════════╧═══════════╝
 
 ╔═════════════════╤══════════╤══════════╗
 ║ @glimmer/*      │ Min      │ Gzip     ║
 ╟─────────────────┼──────────┼──────────╢
-║ Total           │ 38.38 KB │ 21.75 KB ║
+║ Total           │ 38.38 KB │ 21.74 KB ║
 ╟─────────────────┼──────────┼──────────╢
 ║ destroyable     │ 2.78 KB  │ 1.38 KB  ║
 ║ encoder         │ 81 B     │ 171 B    ║
@@ -53,7 +53,7 @@
 ║ program         │ 252 B    │ 308 B    ║
 ║ reference       │ 548 B    │ 544 B    ║
 ║ runtime         │ 10.32 KB │ 5.21 KB  ║
-║ tracking        │ 1.34 KB  │ 1.18 KB  ║
+║ tracking        │ 1.34 KB  │ 1.17 KB  ║
 ║ util            │ 1.94 KB  │ 1.6 KB   ║
 ║ validator       │ 15.53 KB │ 6.9 KB   ║
 ║ vm              │ 495 B    │ 569 B    ║

Details

This PR main

╔═══════╤═══════════╤═══════════╗
║       │ Min       │ Gzip      ║
╟───────┼───────────┼───────────╢
║ Total │ 351.99 KB │ 203.81 KB ║
╚═══════╧═══════════╧═══════════╝

╔══════════════════════╤═══════════╤═══════════╗
║ @ember/*             │ Min       │ Gzip      ║
╟──────────────────────┼───────────┼───────────╢
║ Total                │ 313.6 KB  │ 182.07 KB ║
╟──────────────────────┼───────────┼───────────╢
║ -internals           │ 36.61 KB  │ 25.96 KB  ║
║ application          │ 13.24 KB  │ 8.13 KB   ║
║ array                │ 13.05 KB  │ 7.55 KB   ║
║ canary-features      │ 304 B     │ 419 B     ║
║ component            │ 2.05 KB   │ 1.61 KB   ║
║ controller           │ 1.9 KB    │ 1.43 KB   ║
║ debug                │ 11.73 KB  │ 8.16 KB   ║
║ deprecated-features  │ 31 B      │ 77 B      ║
║ destroyable          │ 561 B     │ 383 B     ║
║ enumerable           │ 259 B     │ 387 B     ║
║ helper               │ 1.08 KB   │ 834 B     ║
║ instrumentation      │ 2.43 KB   │ 1.78 KB   ║
║ modifier             │ 1.22 KB   │ 984 B     ║
║ object               │ 35.84 KB  │ 22.23 KB  ║
║ owner                │ 159 B     │ 178 B     ║
║ renderer             │ 630 B     │ 494 B     ║
║ routing              │ 59.37 KB  │ 34.05 KB  ║
║ runloop              │ 2.36 KB   │ 1.45 KB   ║
║ service              │ 1 KB      │ 855 B     ║
║ template             │ 654 B     │ 541 B     ║
║ template-compilation │ 429 B     │ 366 B     ║
║ template-compiler    │ 123.33 KB │ 59.61 KB  ║
║ template-factory     │ 370 B     │ 385 B     ║
║ test                 │ 923 B     │ 627 B     ║
║ utils                │ 4.11 KB   │ 3.62 KB   ║
║ version              │ 55 B      │ 131 B     ║
╚══════════════════════╧═══════════╧═══════════╝

╔═════════════════╤══════════╤══════════╗
║ @glimmer/*      │ Min      │ Gzip     ║
╟─────────────────┼──────────┼──────────╢
║ Total           │ 38.38 KB │ 21.74 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable     │ 2.78 KB  │ 1.38 KB  ║
║ encoder         │ 81 B     │ 171 B    ║
║ env             │ 38 B     │ 87 B     ║
║ global-context  │ 886 B    │ 545 B    ║
║ manager         │ 977 B    │ 627 B    ║
║ node            │ 175 B    │ 268 B    ║
║ opcode-compiler │ 1.11 KB  │ 905 B    ║
║ owner           │ 159 B    │ 202 B    ║
║ program         │ 252 B    │ 308 B    ║
║ reference       │ 548 B    │ 544 B    ║
║ runtime         │ 10.32 KB │ 5.21 KB  ║
║ tracking        │ 1.34 KB  │ 1.17 KB  ║
║ util            │ 1.94 KB  │ 1.6 KB   ║
║ validator       │ 15.53 KB │ 6.9 KB   ║
║ vm              │ 495 B    │ 569 B    ║
║ wire-format     │ 1.84 KB  │ 1.35 KB  ║
╚═════════════════╧══════════╧══════════╝

╔═══════╤═══════════╤═══════════╗
║       │ Min       │ Gzip      ║
╟───────┼───────────┼───────────╢
║ Total │ 352.26 KB │ 203.59 KB ║
╚═══════╧═══════════╧═══════════╝

╔══════════════════════╤═══════════╤═══════════╗
║ @ember/*             │ Min       │ Gzip      ║
╟──────────────────────┼───────────┼───────────╢
║ Total                │ 313.87 KB │ 181.83 KB ║
╟──────────────────────┼───────────┼───────────╢
║ -internals           │ 36.68 KB  │ 25.99 KB  ║
║ application          │ 13.24 KB  │ 7.99 KB   ║
║ array                │ 13.05 KB  │ 7.54 KB   ║
║ canary-features      │ 304 B     │ 419 B     ║
║ component            │ 2.05 KB   │ 1.63 KB   ║
║ controller           │ 1.96 KB   │ 1.45 KB   ║
║ debug                │ 11.73 KB  │ 8.14 KB   ║
║ deprecated-features  │ 31 B      │ 77 B      ║
║ destroyable          │ 561 B     │ 383 B     ║
║ enumerable           │ 259 B     │ 387 B     ║
║ helper               │ 1.08 KB   │ 841 B     ║
║ instrumentation      │ 2.43 KB   │ 1.78 KB   ║
║ modifier             │ 1.22 KB   │ 991 B     ║
║ object               │ 35.98 KB  │ 22.1 KB   ║
║ owner                │ 159 B     │ 178 B     ║
║ renderer             │ 630 B     │ 509 B     ║
║ routing              │ 59.37 KB  │ 33.94 KB  ║
║ runloop              │ 2.36 KB   │ 1.5 KB    ║
║ service              │ 1 KB      │ 858 B     ║
║ template             │ 654 B     │ 535 B     ║
║ template-compilation │ 429 B     │ 366 B     ║
║ template-compiler    │ 123.33 KB │ 59.61 KB  ║
║ template-factory     │ 370 B     │ 385 B     ║
║ test                 │ 923 B     │ 627 B     ║
║ utils                │ 4.11 KB   │ 3.63 KB   ║
║ version              │ 55 B      │ 131 B     ║
╚══════════════════════╧═══════════╧═══════════╝

╔═════════════════╤══════════╤══════════╗
║ @glimmer/*      │ Min      │ Gzip     ║
╟─────────────────┼──────────┼──────────╢
║ Total           │ 38.38 KB │ 21.75 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable     │ 2.78 KB  │ 1.38 KB  ║
║ encoder         │ 81 B     │ 171 B    ║
║ env             │ 38 B     │ 87 B     ║
║ global-context  │ 886 B    │ 545 B    ║
║ manager         │ 977 B    │ 627 B    ║
║ node            │ 175 B    │ 268 B    ║
║ opcode-compiler │ 1.11 KB  │ 905 B    ║
║ owner           │ 159 B    │ 202 B    ║
║ program         │ 252 B    │ 308 B    ║
║ reference       │ 548 B    │ 544 B    ║
║ runtime         │ 10.32 KB │ 5.21 KB  ║
║ tracking        │ 1.34 KB  │ 1.18 KB  ║
║ util            │ 1.94 KB  │ 1.6 KB   ║
║ validator       │ 15.53 KB │ 6.9 KB   ║
║ vm              │ 495 B    │ 569 B    ║
║ wire-format     │ 1.84 KB  │ 1.35 KB  ║
╚═════════════════╧══════════╧══════════╝

NullVoxPopuli · 2026-02-08T22:40:41Z

packages/@ember/-internals/glimmer/lib/component-managers/curly.ts

+    // Set internal symbol-keyed properties directly on the instance.
+    // These are not passed through create() because Object.keys() doesn't
+    // enumerate Symbol properties.
+    (component as any)[ARGS] = capturedArgs;


If we get rid of curly components, we can get rid of this

That'd need an RFC + deprecation

Ofc. Asd is outside the scope and random cleanup

NullVoxPopuli added 2 commits February 8, 2026 16:25

Remove some IE11 support

9224b4b

Remove references to symbol

e6fb6a9

NullVoxPopuli commented Feb 8, 2026

View reviewed changes

Remove reference to isInternalSymbol

315604d

NullVoxPopuli changed the title ~~Remove some IE11 support~~ Remove some IE11 support (Symbols) Feb 8, 2026

Make sure ARGS and HAS_BLOCK are still acceessible (without big changes)

3603790

NullVoxPopuli commented Feb 8, 2026

View reviewed changes

NullVoxPopuli marked this pull request as ready for review February 8, 2026 22:40

NullVoxPopuli requested review from ef4 and kategengler February 8, 2026 22:41

driesdl approved these changes Feb 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove some IE11 support (Symbols)#21079

Remove some IE11 support (Symbols)#21079
NullVoxPopuli wants to merge 4 commits intomainfrom
nvp/remove-some-ie11-support

NullVoxPopuli commented Feb 8, 2026 •

edited

Loading

Uh oh!

NullVoxPopuli Feb 8, 2026

Uh oh!

github-actions bot commented Feb 8, 2026 •

edited

Loading

Uh oh!

NullVoxPopuli Feb 8, 2026

Uh oh!

kategengler Feb 8, 2026

Uh oh!

NullVoxPopuli Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

NullVoxPopuli commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NullVoxPopuli Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NullVoxPopuli Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

kategengler Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

NullVoxPopuli Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NullVoxPopuli commented Feb 8, 2026 •

edited

Loading

github-actions bot commented Feb 8, 2026 •

edited

Loading