Skip to content

test_viewports: fix assertion #7693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 24, 2025
+3 −3
Merged

test_viewports: fix assertion #7693

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c3ed164
Fix Assertion
YichiZhang0613 Nov 9, 2025
d2fe934
Fix typo: 'then' -> 'than'
emilk Nov 13, 2025
8ad6282
Fix typo: 'then' -> 'than'
emilk Nov 13, 2025
fd3e5f7
Fix typo: 'then' -> 'than'
emilk Nov 13, 2025
b8b27f1
Merge branch 'emilk:main' into fix_assertion
YichiZhang0613 Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/test_viewports/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ fn drag_and_drop_test(ui: &mut egui::Ui) {
}

fn insert(&mut self, container: Id, col: usize, value: impl Into<String>) {
assert!(col <= COLS, "The coll should be less then: {COLS}");
assert!(col < COLS, "The coll should be less then: {COLS}");

let value: String = value.into();
let id = Id::new(format!("%{}% {}", self.counter, &value));
Expand All @@ -355,7 +355,7 @@ fn drag_and_drop_test(ui: &mut egui::Ui) {
}

fn cols(&self, container: Id, col: usize) -> Vec<(Id, String)> {
assert!(col <= COLS, "The col should be less then: {COLS}");
assert!(col < COLS, "The col should be less then: {COLS}");
let container_data = &self.containers_data[&container];
container_data[col]
.iter()
Expand All @@ -368,7 +368,7 @@ fn drag_and_drop_test(ui: &mut egui::Ui) {
let Some(id) = self.is_dragged.take() else {
return;
};
assert!(col <= COLS, "The col should be less then: {COLS}");
assert!(col < COLS, "The col should be less then: {COLS}");

// Should be a better way to do this!
#[expect(clippy::iter_over_hash_type)]
Expand Down
Loading