Conversation
Owner
|
@alexislg2 I think this patch belongs to pdu package. What do you think? |
Contributor
Author
|
Why not but you have to keep the possibility for the user using modem.js of not having to select an encoding (exactly like your mobile phone does: you type your text, select a recipient and it chooses the encoding for you depending of the characters in your text) |
Owner
|
I agree that the patch is useful. All I'm saying is that pdu.js should do it, not modem. |
Contributor
Author
|
OK
|
Contributor
Author
|
But il will only work if you also merge my PR on pdu.js for using GSM 7-bit alphabet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If encoding is not specified this PR can choose the best one for you