Skip to content

Remove mac arm64 workaround from test runner. NFC #25736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

Remove mac arm64 workaround from test runner. NFC #25736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions test/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import math
import operator
import os
import platform
import random
import sys
import time
Expand Down Expand Up @@ -420,9 +419,7 @@ def run_tests(options, suites):
print('Test suites:', [s[0] for s in suites])
# Run the discovered tests

# We currently don't support xmlrunner on macOS M1 runner since
# `pip` doesn't seeem to yet have pre-built binaries for M1.
if os.getenv('CI') and not (utils.MACOS and platform.machine() == 'arm64'):
if os.getenv('CI'):
os.makedirs('out', exist_ok=True)
# output fd must remain open until after testRunner.run() below
output = open('out/test-results.xml', 'wb')
Expand Down