Support window selector in shell.html#6374
Closed
atrosinenko wants to merge 1 commit intoemscripten-core:incomingfrom
Closed
Support window selector in shell.html#6374atrosinenko wants to merge 1 commit intoemscripten-core:incomingfrom
atrosinenko wants to merge 1 commit intoemscripten-core:incomingfrom
Conversation
This makes possible implementation of multi-window support in SDL2.
Contributor
Author
|
According to @Daft-Freak from SDL2 port, this PR should be reworked, so for every "window" a separate canvas be created to not mess things up when GL is used. Now this PR should be considered suspended for a while. |
|
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 7 days. Feel free to re-open at any time if this issue is still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my port of QEMU to JavaScript I use their SDL2 UI for graphics. Previously, I had to disable every window except one, otherwise the canvas was messed up. There is also an issue #5081 on this topic.
In this PR I add the basic support for window selector to Emscripten. SDL2 support requires separate PR to its repository, though: emscripten-ports/SDL2#55.
PS: Frankly speaking, I'm not familiar with OpenGL at all, but it seems to work in my QEMU port. Corrections are welcome, of course.