Repository navigation
Cinematic, TalkBehavior: Rename property title to cue - #3057
Merged
Merged
Conversation
To match the Dialogue Manager change in v4. Add setters for migration. Map the old property name to the new one in TalkBehavior, Cinematic and CollectibleItem, so scenes saved before this change keep their cue (StoryQuest contributions, for example). The editor saves them with the new name. Conceptually this is the same idea as `_get_item()` in cd5d922, in which the editor saves the converted value. But in this case the property name itself changes. Update every scene and script that sets the property. Resolve #2856
|
Play this branch at https://play.threadbare.game/branches/endlessm/title-to-cue/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To match the Dialogue Manager change in v4.
Add setters for migration. Map the old property name to the new one in TalkBehavior, Cinematic and CollectibleItem, so scenes saved before this change keep their cue (StoryQuest contributions, for example). The editor saves them with the new name. Conceptually this is the same idea as
_get_item()in cd5d922, in which the editor saves the converted value. But in this case the property name itself changes.Update every scene and script that sets the property.
Resolve #2856