Skip to content

Conversation

@vorburger
Copy link
Member

@vorburger vorburger commented Aug 6, 2025

Relates to #1450 - this is a simplified version of that, using using only @RecordBuilder and not even @RecordInterface ...

... but, as far as I can tell (unless I'm just stupid and missing something obvious) even this still does not work - the (Bazel) build still fails with an error: package ExampleRecordBuilder does not exist due to that ExampleRecordBuilder.builder.build(); in the YamlObjectReaderWriterTest - see Randgalt/record-builder#231.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request initiates the integration of the Randgalt/record-builder library to enable automatic generation of builder patterns for Java records. It involves updating build configurations (Bazel) and dependency declarations to support this new functionality. The author notes that this is an exploratory step, and the build is currently failing, indicating ongoing work to resolve the integration challenges.

Highlights

  • New Library Integration: This pull request introduces the Randgalt/record-builder library (io.soabase.record-builder:record-builder-core and io.soabase.record-builder:record-builder-processor) to the project. This library is intended to automatically generate builder classes for Java records, simplifying their construction.
  • Application of Record Builder: The @RecordBuilder annotation has been applied to java/dev/enola/common/io/object/ExampleRecord.java, indicating that a builder should be generated for this specific record. A test case in YamlObjectReaderWriterTest.java was updated to attempt using this generated builder.
  • Bazel Build System Configuration: The Bazel build configuration has been updated across multiple files (MODULE.bazel, java/dev/enola/common/io/object/BUILD, tools/bazel/java_plugin/BUILD) to properly include the new record-builder dependencies and configure its annotation processor. This includes defining a new java_plugin for record-builder.
  • Dependency Management Updates: The maven_install.json and docs/dev/dependencies.txt files have been updated to reflect the newly added record-builder and java-composer dependencies, including their versions and shasums. Notably, the com.google.auto.value:auto-value dependency and its corresponding Bazel plugin have been removed, suggesting a potential shift or consolidation in how value objects are handled.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to replace auto-value with io.soabase.record-builder for generating builders for record classes. The changes correctly update dependencies and build configurations in MODULE.bazel and BUILD files to introduce record-builder.

My main feedback is related to the build failure you're observing. I suspect a transitive dependency, com.squareup:javapoet, is missing from your resolved dependencies, which is crucial for the record-builder annotation processor to generate code. I've provided suggestions to explicitly add this dependency, which should hopefully resolve the build issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant