-
Notifications
You must be signed in to change notification settings - Fork 162
Add Porto #1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gskril
wants to merge
14
commits into
main
Choose a base branch
from
feat/porto
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Porto #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Deploying ens-app-v3 with
|
| Latest commit: |
e55313f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d26c2137.ens-app-v3.pages.dev |
| Branch Preview URL: | https://feat-porto.ens-app-v3.pages.dev |
|
…ests Removes the records setup from tests for unauthorized and invalid resolver scenarios to avoid transaction conflicts with nonce management. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The getPrimaryNameQueryFn always returns originalName when returning a non-null result, so the type should reflect this. Also fixes import ordering in wagmi.ts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…aits - Replace arbitrary page.waitForTimeout with testClient.mine for transaction mining - Use waitFor with specific text matchers instead of generic expect assertions - Add waitForLoadState after page reloads for stability - Click complete button to properly finish transaction flows 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add 5-second timeout before clicking edit profile button to ensure page is fully loaded - Mine blockchain block after makeName to ensure state consistency - Remove redundant records configuration from outdated resolver tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Porto (website / github) is a new smart wallet, similar to Coinbase Smart Wallet which we already support
Successfully registered a name on Sepolia https://sepolia.app.ens.domains/kajsdfkjasdf.eth
Notes: