Skip to content

name change + extra check #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laurgk wants to merge 5 commits into
base: main
Choose a base branch
from
Open

name change + extra check #1088

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
599199e
name change + extra check
laurgk Nov 13, 2025
648c581
extra
laurgk Nov 13, 2025
2e4dcb3
Merge branch 'main' into address-page-extra
storywithoutend Nov 25, 2025
6dcbc8f
Merge branch 'main' into address-page-extra
storywithoutend Nov 26, 2025
1cdffce
Merge branch 'main' into address-page-extra
storywithoutend Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions ...tateless/addressPageErrorHandling.spec.ts → e2e/specs/stateless/addressPage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,30 @@ test.describe('Address page error handling', () => {
expect(requestCount).toBeGreaterThanOrEqual(3) // At least 2 failures + 1 success
})

test('should display no-profile-snippet when no primary name set with invalid resolver', async ({
page,
login,
makeName,
makePageObject,
}) => {
test.slow()

// SETUP: Create name with invalid resolver (triggers ContractFunctionExecutionError)
// Deliberately NOT setting as primary name to test no-primary-name scenario
const name = await createUserName(makeName, 'no-primary-invalid-resolver')
await setInvalidResolver(page, name, login, makePageObject)

// ACTION: Navigate to address page
const userAddress = getUserAddress()
await page.goto(`/${userAddress}`)

// ASSERT: Page loads gracefully showing no-profile-snippet (not profile-snippet)
await expect(page.getByTestId('no-profile-snippet')).toBeVisible()

// ASSERT: Names list loads despite invalid resolver on owned name
await expect(page.getByTestId('names-list')).toBeVisible({ timeout: NAMES_LIST_TIMEOUT })
})

test.afterEach(async () => {
// Clean up: reset primary name after each test
await setPrimaryName(walletClient, {
Expand Down