[auth] Fix custom order button tap #7784
Conversation
Previously, tapping "Custom order" from a different sort order would only switch to custom order but not open the rearrange screen. Users had to tap the sort button again and click "edit" beside Custom order to access it. Fixed by removing the condition that checked if the current sort was already manual, so now selecting custom order immediately opens the rearrange screen.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| currentKey: PreferenceService.instance.codeSortKey(), | ||
| onSelected: (newOrder) async { | ||
| await PreferenceService.instance.setCodeSortKey(newOrder); | ||
| if (newOrder == CodeSortKey.manual && newOrder == _codeSortKey) { | ||
| if (newOrder == CodeSortKey.manual) { | ||
| await navigateToReorderPage(_allCodes!); | ||
| } |
There was a problem hiding this comment.
The null assertion _allCodes! is now reached whenever the user taps “Custom order”, even if the codes list has not finished loading. Early in page startup _allCodes is still null, so changing the sort to manual immediately triggers a crash before the codes stream populates. The previous condition required the current sort to already be manual, which significantly reduced the chance of hitting this path before _allCodes was initialized. Consider skipping navigation or awaiting data when _allCodes is null to avoid a runtime exception.
Useful? React with 👍 / 👎.
1 participant
Description
Previously, tapping "Custom order" from a different sort order would only switch to custom order but not open the rearrange screen. Users had to tap the sort button again and click "edit" beside Custom order to access it.
Fixed by removing the condition that checked if the current sort was already manual, so now selecting custom order immediately opens the rearrange screen.
Tests