Maint: Fix correctness in Enum default traitsui editor#1012
Merged
Conversation
ievacerny
approved these changes
Apr 28, 2020
Contributor
ievacerny
left a comment
There was a problem hiding this comment.
The code looks good and I can verify that Enum dropdown now shows "FALSE" and "TRUE" instead of "0" and "1" 👍
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #965
This PR:
value = self(selfis an instance ofEnum) tovalue = self.values. Both works, but the latter is more correct.format_funcis provided. I'd not recommend puttingformat_funcin the definition of trait, but it needs to stay for backward compatibility.For example, this:
We'd expect to see the dropdown contains
"TRUE"and"FALSE". enthought/traitsui#782 causes us to see"0"and"1"instead.Checklist
Not testing the effect of
format_funchere to reduce test dependencies on traitsui. See previous discussion in Add a GUI test for Enum.create_editor #988. See Move default traitsui editors over to traitsui #1004 as well.Update API reference (docs/source/traits_api_reference)Update User manual (docs/source/traits_user_manual)Update type annotation hints intraits-stubs