Improve user feedback when CloudFormation reports no changes #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When CloudFormation returns 'no changes' errors during apply, provide a clearer explanation that while the template may have differences (e.g., whitespace, comments, formatting), no actual resource changes are needed and the stack is already in the desired state. This addresses the confusing scenario where users see a template diff but CloudFormation reports: 'The submitted information didn't contain changes. Submit different information to create a change set.' Changes: - Add user_friendly_changeset_error method to detect common 'no changes' error messages and provide helpful context - Update both create and update stack flows to use the improved message - Add comprehensive tests covering various CloudFormation error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When running
stack_master apply, CloudFormation occasionally reports "The submitted information didn't contain changes. Submit different information to create a change set." This occurs even when stack_master displays a template diff, which confuses users. The issue arises when template changes are cosmetic (whitespace, comments, formatting) or don't affect actual resources, but the error message doesn't explain this clearly.Changes
user_friendly_changeset_errorhelper method to detect common "no changes" error patterns and provide clearer explanationResolves #244.