-
Notifications
You must be signed in to change notification settings - Fork 587
feat: allow more compressor overrides #7406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2e305d6 to
8a5b844
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7406 +/- ##
==========================================
+ Coverage 72.36% 72.37% +0.01%
==========================================
Files 231 231
Lines 34042 34011 -31
==========================================
- Hits 24633 24617 -16
+ Misses 7633 7623 -10
+ Partials 1776 1771 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| envoy.filters.http.compression: | ||
| "@type": type.googleapis.com/envoy.extensions.filters.http.compressor.v3.CompressorPerRoute | ||
| overrides: | ||
| {{- if .PrometheusCompressionRemoveAcceptEncodingHeader }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinking this loud, should we move 19001 to dynamic listener
cc @envoyproxy/gateway-maintainers
2b2606e to
ce5e36f
Compare
|
/retest |
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
Signed-off-by: Steven Kreitzer <[email protected]>
4c6f00a to
587d9a5
Compare
|
/retest |
|
@arkodg Can I get a review please? :-) |
This adds a new
chooseFirstandremoveAcceptEncodingHeaderto each compressor.When
chooseFirstis true, the compressor is preferred when q-values in Accept-Encoding are equal. If multiple compressor filters set choose_first to true, the last one in the filter chain is chosen.When
removeAcceptEncodingHeaderis true, removes Accept-Encoding from the request headers before dispatching the request to the upstream so that responses do not get compressed before reaching the filter.I also clean up some of the code in various places. There was some duplication happening.
Note: These are currently only offered as a "global" setting as chooseFirst is not overridable per route, so I made both like that.
Closes #5796