Improve handling of longer PV names#88
Open
eddybl wants to merge 2 commits into
Open
Conversation
anjohnson
reviewed
Mar 12, 2026
fdbaff3 to
1ebfe8b
Compare
1ebfe8b to
0632ba7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autosave defines a
PV_NAME_LENfor the maximum allowed length of PVs. But there are various locations where the code uses other hard coded limits, which is sometimes 80 and sometimes 63.PV_NAME_LENmore consistently.Background
We are using a slightly patched version of EPICS base, which increases the PV length limit from 61 to 256. While the patch itself is very small, only changing two lines of code ( https://gitlab.kit.edu/kit/ibpt/controls/epics/distribution/epics-build-tool/-/blob/master/customizations/ibpt/patches/base/01-record-name-length.patch ), autosave is not compatible to that. We therefore use this patched version of autosave since around 2019.
At least one other institute recently also started using our EPICS base patch and were encountering the same issue with autosave, so the idea came up to submit the patch upstream. The currently used number for
PV_NAME_LENseemed to be arbitrary anyway, so we could as well define a higher number ;)