-
Notifications
You must be signed in to change notification settings - Fork 2
chore(ci): initial setup of CI & Makefile using pulumi/ci-mgmt #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: drop-pf-shim
Are you sure you want to change the base?
Conversation
| @@ -1,42 +0,0 @@ | |||
| # WARNING: This file was build based on https://github.com/pulumi/ci-mgmt | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the upgrade-provider workflow has been updated to run on a schedule instead of running when an issue is opened, so there's no longer a need for a separate check workflow that discovers new provider versions and creates an issue.
| id-token: write # For ESC secrets. | ||
|
|
||
| env: | ||
| GH_TOKEN: ${{ secrets.EQUINIX_BOT_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the updated workflows look for PULUMI_PROVIDER_AUTOMATION_TOKEN, so we can put our token there instead. That's likely more straightforward than modifying the generated workflows to keep our old bot token secret name.
| PULUMI_SKIP_MISSING_MAPPING_ERROR: true | ||
| PULUMI_SKIP_EXTRA_MAPPING_ERROR: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We manually added these PULUMI_SKIP_ environment variables to a couple of workflows to smooth out the upgrade process. Having these in all workflows would be bad--we don't want to release broken providers--but it doesn't look like pulumi/ci-mgmt gives the kind of granular control we would need to only have these environment variables in some workflows but not in others. It's probably better to lose these if it means we can follow a standard development process.
| name: publish | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| new_release_version: ${{ steps.semantic_release.outputs.new_release_version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to move this semantic release logic to a separate workflow file so that it is not overwritten by ci-mgmt. If it isn't already, the semantic release workflow will need to be created with our own bot token so that the tag it creates will trigger this ci-mgmt-managed release workflow.
59f60e4 to
4688aab
Compare
4688aab to
850028d
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
| @@ -1,24 +1,37 @@ | |||
| # WARNING: This file is autogenerated - changes will be overwritten when regenerated by https://github.com/pulumi/ci-mgmt | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated linter is failing, so we should revert to the old files for now. We can regenerate the new linter stuff later.
Makefile
Outdated
| $(WORKING_DIR)/bin/${TFGEN} schema --out provider/cmd/${PROVIDER} | ||
| (cd provider && VERSION=$(VERSION) go generate cmd/${PROVIDER}/main.go) | ||
|
|
||
| bin/pulumi-java-gen: .pulumi-java-gen.version $(PULUMICTL_BIN) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should bring back the old java gen logic for now and then upgrade to the bridge-native java generator in a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we need to manually navigate the transition from pulumi-java-gen to pulumi-language-java regardless of what CI is in place, we might as well get #311 figured out first and then revisit this one after we've dropped pulumi-java-gen.
f329d57 to
6bd72bb
Compare
|
6bd72bb to
c75979b
Compare
7ca55ef to
520c65d
Compare
c75979b to
cc35f4e
Compare
520c65d to
9a60cbe
Compare
cc35f4e to
cfbb153
Compare
9a60cbe to
b6ab8e7
Compare
- Checked out github.com/pulumi/ci-mgmt - Built the `provider-ci` tool - Ran `./bin/provider-ci generate --name equinix/pulumi-equinix --config ~/Documents/code/pulumi-equinix/.ci-mgmt.yaml --out ~/Documents/code/pulumi-equinix/`
cfbb153 to
2df8b19
Compare
This PR aims to fix our broken CI workflows and make it easier to catch up with future changes to how bridged Pulumi providers are developed.
I added an initial
.ci-mgmt.yamlfile and then ran theprovider-citool as described in the pulumi/ci-mgmt docs to generate the standard Pulumi workflows.