refactor: replace isStringInSlice with slices.Contains #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
approved these changes
May 16, 2024
Contributor
ctreatma
left a comment
ctreatma
left a comment
There was a problem hiding this comment.
DRE sign-off is required because these changes touch provider.go, but codeowner review should be obtained for the other files.
thogarty
approved these changes
May 16, 2024
Contributor
thogarty
left a comment
thogarty
left a comment
There was a problem hiding this comment.
LGTM. Thanks @displague
Signed-off-by: Marques Johansson <[email protected]>
ctreatma
pushed a commit
that referenced
this pull request
Jul 11, 2024
This PR moves the helper functions from provider.go to a new comparisons package. This package will be used by provider, tests, and resources. The refactoring will assist with splitting resources into resource specific packages. #106 The previous helper functions have been deprecated and will be removed in a future commit. Extracted from #622 (PR grew to large to maintain. Refactoring is not a priority and rebasing gets hard as the underlying code changes) Related to #674 Related to #654 Signed-off-by: Marques Johansson <[email protected]>
kpdhulipala
pushed a commit
to kpdhulipala/terraform-provider-equinix
that referenced
this pull request
Mar 24, 2025
Remove isStringInSlice in favor of slices.Contains. Extracted from equinix#622 Related to equinix#665 Signed-off-by: Marques Johansson <[email protected]>
kpdhulipala
pushed a commit
to kpdhulipala/terraform-provider-equinix
that referenced
this pull request
Mar 24, 2025
This PR moves the helper functions from provider.go to a new comparisons package. This package will be used by provider, tests, and resources. The refactoring will assist with splitting resources into resource specific packages. equinix#106 The previous helper functions have been deprecated and will be removed in a future commit. Extracted from equinix#622 (PR grew to large to maintain. Refactoring is not a priority and rebasing gets hard as the underlying code changes) Related to equinix#674 Related to equinix#654 Signed-off-by: Marques Johansson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove isStringInSlice in favor of slices.Contains.
Extracted from #622
Related to #665