-
Notifications
You must be signed in to change notification settings - Fork 49
feat: Add selective redundancy field #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for a selective redundancy field to the Equinix Fabric Service Profile resource and data sources. The selective redundancy field allows for optional redundant connections, as opposed to the existing connection_redundancy_required field which mandates redundancy.
Key changes:
- Added
selective_redundancyboolean field to service profile access point type configuration - Updated resource and data source schemas to include the new field
- Added corresponding Go SDK integration for reading and writing the field
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tf.json | Test data file containing sample JSON structures with device redundancy configurations |
| equinix/resource_fabric_service_profile.go | Added selective_redundancy field to schema and implemented conversion logic between Terraform and Go SDK representations |
| docs/resources/fabric_service_profile.md | Added documentation for the new selective_redundancy optional field |
| docs/data-sources/fabric_service_profiles.md | Added documentation for selective_redundancy in the data source schema |
| docs/data-sources/fabric_service_profile.md | Added documentation for selective_redundancy in the singular data source schema |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0e01b06 to
d7c9bad
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
===========================================
+ Coverage 29.21% 66.57% +37.35%
===========================================
Files 245 245
Lines 28353 28361 +8
===========================================
+ Hits 8284 18882 +10598
+ Misses 19915 8560 -11355
- Partials 154 919 +765 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d7c9bad to
6c13810
Compare
6c13810 to
2b30b4d
Compare
698a544 to
e204d1d
Compare
|
This PR is included in version 4.10.0 🎉 |


No description provided.