Skip to content

Conversation

@d-bhola
Copy link
Contributor

@d-bhola d-bhola commented Nov 7, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 7, 2025 23:16
@d-bhola d-bhola requested review from a team as code owners November 7, 2025 23:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a selective redundancy field to the Equinix Fabric Service Profile resource and data sources. The selective redundancy field allows for optional redundant connections, as opposed to the existing connection_redundancy_required field which mandates redundancy.

Key changes:

  • Added selective_redundancy boolean field to service profile access point type configuration
  • Updated resource and data source schemas to include the new field
  • Added corresponding Go SDK integration for reading and writing the field

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tf.json Test data file containing sample JSON structures with device redundancy configurations
equinix/resource_fabric_service_profile.go Added selective_redundancy field to schema and implemented conversion logic between Terraform and Go SDK representations
docs/resources/fabric_service_profile.md Added documentation for the new selective_redundancy optional field
docs/data-sources/fabric_service_profiles.md Added documentation for selective_redundancy in the data source schema
docs/data-sources/fabric_service_profile.md Added documentation for selective_redundancy in the singular data source schema

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 73.33333% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.57%. Comparing base (aa20777) to head (8990399).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
equinix/resource_fabric_service_profile.go 73.33% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #973       +/-   ##
===========================================
+ Coverage   29.21%   66.57%   +37.35%     
===========================================
  Files         245      245               
  Lines       28353    28361        +8     
===========================================
+ Hits         8284    18882    +10598     
+ Misses      19915     8560    -11355     
- Partials      154      919      +765     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-bhola
Copy link
Contributor Author

d-bhola commented Nov 8, 2025

In Response:
image

@d-bhola
Copy link
Contributor Author

d-bhola commented Nov 8, 2025

In Request:
image

@d-bhola d-bhola merged commit be55576 into main Nov 8, 2025
13 of 18 checks passed
@d-bhola d-bhola deleted the CXF-116478-sp-selective branch November 8, 2025 15:05
@github-actions
Copy link

github-actions bot commented Nov 8, 2025

This PR is included in version 4.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants