Open
Conversation
Collaborator
larsevj
commented
Sep 17, 2025
larsevj
commented
- Fixes searchpath in runmetoupdate.sh
larsevj
force-pushed
the
fix_and_update_opm_keywords
branch
from
0c20a68 to
b2d39d2
Compare
alifbe
reviewed
Sep 22, 2025
Comment on lines
+73
to
+89
| { | ||
| "item": 10, | ||
| "name": "EQLOPT04", | ||
| "value_type": "INT", | ||
| "comment": "This item is ECLIPSE300 specific" | ||
| }, | ||
| { | ||
| "item": 11, | ||
| "name": "EQLOPT5", | ||
| "value_type": "INT", | ||
| "comment": "This item is ECLIPSE300 specific" | ||
| }, | ||
| { | ||
| "item": 12, | ||
| "name": "BLACK_OIL_INIT_HG", | ||
| "value_type": "INT", | ||
| "default": 0 |
Collaborator
There was a problem hiding this comment.
I think the test failed due to more columns expected in the new version of opmkeywords
larsevj
force-pushed
the
fix_and_update_opm_keywords
branch
from
e727b37 to
2f5f424
Compare
Collaborator
Author
|
This last test is not entirely clear to me how to solve. Since EQLOPT04 and (5) do not have any default values they get assigned Line 342 in c0699bc (note that a few lines above one assigns np.nan... in another code path). When the keyword dataframes are merged, one gets None values for the rows belonging to EQUIL and nan for the row belonging to the other keywords that do not have values for this column...The reason the test fails is because when the dataframe is written to csv and read again they all become nan, whereas the one from csv2res has a mix of None and nan..
|
larsevj
force-pushed
the
fix_and_update_opm_keywords
branch
from
f154a74 to
eb9e2c1
Compare
larsevj
force-pushed
the
fix_and_update_opm_keywords
branch
from
0deabe8 to
cdf2256
Compare
Collaborator
Author
|
Not sure if the changed names are breaking or not? |
Collaborator
Which changed names? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.