Add DownCast for register id in executeFromSelfReg() #1089
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ergoplatform#602 - Add automatic downcasting from numeric types to Int for register id parameter in executeFromSelfReg() and executeFromSelfRegWithDefault() functions - This mirrors the existing downcast behavior for getVar and executeFromVar - Users can now write executeFromSelfReg[T](4) or executeFromSelfReg[T](4L) without manual .toByte casting Changes: - SigmaTyper.scala: Added downcast logic for ExecuteFromSelfRegFunc and ExecuteFromSelfRegWithDefaultFunc in adaptedTypedArgs pattern matching - SigmaTyperTest.scala: Added comprehensive test cases verifying downcast functionality with Int and Long literals All tests passing (58 tests in SigmaTyperTest suite)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #602
Changes:
All tests passing (58 tests in SigmaTyperTest suite)