fix(http): recover HTTP 421 requests - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A pooled connection can become stale or be coalesced to the wrong origin after proxy or network changes. In the observed Moti + Clash Verge incident, Fastly returned HTTP 421 with a TLS SAN mismatch message. Catcher classified every 4xx as non-retryable, and the NAPI wrapper exposed only a generic Error message, so the application could neither recover locally nor reliably inspect error.status.
Changes
RFC 9110 section 15.5.20 explicitly permits retrying a 421 request over a different connection, even when the method is not idempotent.
Validation
The full pnpm test run completed 345 passed and 1 skipped, with two unrelated harness failures: the randomized packet-loss assertion (passed when rerun alone) and the optional-agent real-proxy CONNECT test. The latter test server handles regular proxy requests but not CONNECT, and this change does not touch the TypeScript proxy implementation.