fix(http): preserve structured transport errors - #28
Merged
JackCaow merged 3 commits intoAug 13, 2026
Conversation
Collaborator
Author
|
Addressed the review findings in b544a0b:
Local validation: cargo check/test/clippy passed for catcher-core, catcher-http, and catcher-napi-http; N-API release build and typecheck passed; focused N-API error-contract tests passed 4/4. |
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Downstream behavior
Moti can now distinguish transport failures from HTTP responses without parsing error text. The downstream compatibility patch retains the existing stateless client rebuild policy, only rebuilds for structured transport causes, and never replays mutation requests.
Validation
The repository-wide pnpm test run completed 345 tests successfully with 1 skipped. Two network-dependent cases failed in the current environment: real proxy forwarding P8, and a stochastic packet-loss case where both vanilla and N-API requests failed. These are outside the focused error-contract regression suite.
Acceptance boundary
The new CI matrix validates the native contract on hosted macOS, Linux, and Windows runners after this PR is opened. A real Windows EV-signed Moti package remains a separate downstream release acceptance gate.