Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VM tracer omits the stack results of PUSH0, TLOAD, BLOBHASH, and BLOBBASEFEE, and omits the memory ranges for MCOPY and EXTCODECOPY. This prevents consumers from reconstructing stack and memory from the compressed trace.
Extend the existing opcode tables and their exhaustive opcode tests. EXTCODECOPY reads its destination and length below the address operand; MCOPY uses the same destination/length positions as the other three-operand copy instructions. The Cancun constants come from the pinned evmone headers because the pinned EVMC opcode enum does not define them.
Validation:
make fmt lintpasses. A focused native C++20 harness compiled the unchanged production helper functions against the pinned evmone/EVMC/intx headers: all six added cases failed on the baseline and pass after the fix. The full RPC test binary has not been built locally; leaving this in draft until that validation is available.Upstream CI: lint passes. The CircleCI Linux build jobs fail before compilation because the project cannot use the configured
2xlargemachine resource class (resource-class-not-in-plan); this is not a test result.Discovered during the evm-trace reconstruction investigation, which compares compressed Parity VM traces expanded into full traces against other tracing methods. The client-side regressions here isolate the affected trace-generation behavior.