SSL distribution protocol fixes for kTLS #10232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaimoNiskanen
added
team:PS
Contributor
CT Test Results 2 files 66 suites 27m 28s ⏱️ Results for commit 071b88f. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
IngelaAndin
reviewed
Sep 23, 2025
IngelaAndin
requested changes
Sep 30, 2025
Contributor
IngelaAndin
left a comment
IngelaAndin
left a comment
There was a problem hiding this comment.
Except for a link comment I think it looks good.
RaimoNiskanen
force-pushed
the
raimo/ssl/dist-fixes
branch
from
ac97ec7 to
ca24a2d
Compare
Contributor
Author
|
I have added a comment about the process link and force pushed |
RaimoNiskanen
force-pushed
the
raimo/ssl/dist-fixes
branch
from
ca24a2d to
071b88f
Compare
IngelaAndin
previously approved these changes
Oct 7, 2025
RaimoNiskanen
dismissed
IngelaAndin’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some chiefly test case glitches for SSL distribution over kTLS, but also removes some unneeded checks when activating kTLS from the regular SSL distribution module
inet_tls_dist, which avoids some rare bogus connection initialization failures.