Skip to content

CT: disable cth_readable_failonly hook when verbose option is set #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

CT: disable cth_readable_failonly hook when verbose option is set #2975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apps/rebar/src/rebar_prv_common_test.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,15 +273,22 @@ add_hooks(Opts, State) ->
true -> [cth_fail_fast];
false -> []
end,
% cth_readable_failonly hides all ct:pal for successful tests.
% When user asks for verbose operation, show these logs
{RawOpts, _} = rebar_state:command_parsed_args(State),
FailOnlyHook = case proplists:get_value(verbose, RawOpts, false) of
true -> [];
false -> [cth_readable_failonly]
end,
case {readable(State), lists:keyfind(ct_hooks, 1, Opts)} of
{false, _} ->
Opts;
{Other, false} ->
[{ct_hooks, [cth_readable_failonly, readable_shell_type(Other),
[{ct_hooks, FailOnlyHook ++ [readable_shell_type(Other),
cth_retry] ++ FailFast ++ cth_log_redirect()} | Opts];
{Other, {ct_hooks, Hooks}} ->
%% Make sure hooks are there once only and add wanted hooks that are not defined yet
ReadableHooks = [cth_readable_failonly, readable_shell_type(Other),
ReadableHooks = FailOnlyHook ++ [readable_shell_type(Other),
cth_retry] ++ FailFast,
NewHooks = Hooks ++ [ReadableHook ||
ReadableHook <- ReadableHooks,
Expand Down
Loading