IPv6 support for getting Hex packages #2978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
or go to hackney which has happy eyeball algorithm and support such fallback? |
Contributor
Author
|
@benoitc Should rebar3 have external dependencies, though? |
Contributor
|
@LEdoian it has already some external depdencies, so why not :) |
Contributor
|
in any case this patch works here. It's very useful for ipv6 only machines. |
ferd
approved these changes
Oct 30, 2025
Collaborator
ferd
left a comment
ferd
left a comment
There was a problem hiding this comment.
Yep, that's a good catch of a thing we had missed!
We do use httpc because long term we hope to get rebar part of OTP, which means minimizing deps as much as we can, whenever we can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2976
I am not sure this is a great way to fix this, but I think it only improves the current state – if the IPv6 does not work, it would fall back to IPv4. Only when IPv6 is broken it would wait till timeout.
I guess we could introduce an environment variable to force a particular IP version, but I am not sure if that is the recommended way.
Also, I am not sure if a test could be written for this, as this depends on the particular network configuration.
Looking forward to hearing feedback!