fix math/number inconsistency - #348
Merged
Merged
Conversation
jhnaldo
force-pushed
the
fix-math-number-inconsistency
branch
from
July 30, 2026 02:23
9286371 to
065439e
Compare
Contributor
|
Thanks for fixing this! I added ExtMath to handle non-finite values properly and refactored the normalization logic for math and number results. Everything looks solid now, so I will go ahead and merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue: #338
Summary
Fix interpreter crashes when implementation-approximated math results become non-finite values such as
InfinityorNaN.The reported case was:
This previously crashed because math.pow(...) could return Double.PositiveInfinity, which was then wrapped as Math(BigDecimal). BigDecimal cannot represent infinity.
Changes
EvalSmallTest passes.