Skip to content

Fix/6473 bash reap memory leak - #6528

Open
myipanta wants to merge 1 commit into
esengine:main-v2from
myipanta:fix/6473-bash-reap-memory-leak
Open

Fix/6473 bash reap memory leak#6528
myipanta wants to merge 1 commit into
esengine:main-v2from
myipanta:fix/6473-bash-reap-memory-leak

Conversation

@myipanta

@myipanta myipanta commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Verification

Cache impact

Cache-impact: none — bash tool output buffering only, no prompt or tool definition changes
Cache-guard: go test ./internal/tool/builtin/ -count=1 covers foreground bash execution
System-prompt-review: N/A

For cache-sensitive changes, fill these lines before requesting review:

  • Cache-impact: none, low, medium, or high, plus the reason.
  • Cache-guard: the focused guard test/command added or run, or why an existing guard covers the change.
  • System-prompt-review: required reviewer/approval note when provider-visible system prompt, memory prefix, output style, or skill index behavior changes.

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) skills Skill system (internal/skill, internal/tool) labels Jul 15, 2026
@myipanta
myipanta force-pushed the fix/6473-bash-reap-memory-leak branch from 4517002 to 06e30df Compare July 15, 2026 12:16
…ocesses (esengine#6473)

Runaway commands that produce unbounded output (e.g. infinite-loop
prints in a Python script) could fill the bytes.Buffer without limit,
causing memory to spike to 96% and the Reasonix process to become
unresponsive. Add a cappedWriter that silently drops writes beyond
10 MB and appends a truncation notice so the model sees a clear
signal that output was cut.
@myipanta
myipanta force-pushed the fix/6473-bash-reap-memory-leak branch from 06e30df to acae489 Compare July 16, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) skills Skill system (internal/skill, internal/tool) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants