Repository navigation
Conversation
feat [PKTS-221]: add file input react component
Cloudflare Pages runs `pnpm turbo run build --filter=react-docs...`, which invokes the react-docs `build` script. That script was `storybook build`, producing only the react-docs Storybook with no subdirectory structure. The assembly script (scripts/assemble-cloudflare.mjs) already existed and built all 4 Storybooks into the correct layout under apps/react-docs/storybook-static/, but was only wired as `build:cloudflare`. Swap: make `build` call the assembly script, rename the direct storybook invocation to `build:storybook` for local use.
The storybook CLI had resolved to 8.6.x while framework packages (@storybook/react-vite, @storybook/web-components-vite, etc.) were pinned at ^8.4.5, resolving to 8.4.5. This split caused two versions of @storybook/preview-api to coexist: 8.4.5 (bundled in the built runtime.js) and 8.6.x (used by the CLI). In preview-api 8.4.5, pathToId() only accepts paths starting with /story/. The 8.6.x manager uses path-based routing and passes /docs/<id> to the preview iframe, which the 8.4.5 runtime rejects with "Invalid path, must start with /story/" causing blank docs pages. Bump all @storybook/* packages in host-docs, react-docs, web-docs, and css-docs to ^8.6.18 so everything resolves to a single consistent version. pnpm-lock.yaml updated accordingly.
…routing fix: [PKTS-255] wire assemble-cloudflare as default react-docs build
Collaborator
Author
|
Closing — direct merge from develop to main, no PR needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes develop to main for Cloudflare Pages production deployment at packets.es.net.
Includes fix/PKTS-255-storybook-cloudflare-routing (PR #100): wires the assembly script as the react-docs default build so Cloudflare Pages builds all four Storybooks, and aligns all Storybook packages to 8.6.18 to fix blank docs pages on navigation.